API Signature Problem: Newlines in Descriptions

Edit Subject

I'm throwing together a chrome extension to post screenshots to Done Done.

When I try to generate a Signed Request, newline characters in descriptions (create an issue, comment), cause the signed request to always be invalid. If I take out the newlines in the body, it works fine. But if I leave the newlines in the request body, but remove the in the signed request, it doesn't work. How do you deal with newlines when generating the request?

Example:

Params:

URL:

https://xxxxxxxx.mydonedone.com/IssueTracker/API/Comment/123/45

comment:

test


ben

A signed request pre hashing and base64:

https://xxxxxxxx.mydonedone.com/IssueTracker/API/Comment/####/##commenttest


ben

What the HTTP Request Body looks like:



------WebKitFormBoundaryZC0TAhfEDRXF6fuv

Content-Disposition: form-data; name="comment"


test


ben

------WebKitFormBoundaryZC0TAhfEDRXF6fuv--

1 person has
this problem +1

0

Edit

Delete

Remove

Official

Ben January 17, 2012 08:25

Note, the getsatisfaction thing strips out multiple blank lines. Between "test" and "ben" should be two blank lines. Though it doesn't make a difference, any newlines breaks the signature.

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Note, the getsatisfaction thing strips out multiple blank lines. Between "test" and "ben" should be two blank lines. Though it doesn't make a difference, any newlines breaks the signature.

How does this make you feel? Add Image

I'm
e.g. kidding, amused, unsure, silly indifferent, undecided, unconcerned sad, anxious, confused, frustrated happy, confident, thankful, excited
Cancel
EMPLOYEE

0

Edit

Delete

Remove

Official

WAM - DoneDone (Official Rep) January 17, 2012 15:19

Hey Ben -

Thanks for checking in, and for reporting the issue. I've forwarded to Mustafa, who is the loving father and caretaker of the DD api. Once he's had a peek and gives a nod and wink to how long it'll take to get patched up, I'll be in touch.

Also, interested in learning a bit about what you're building. If you have a minute or two, can you send along a quick email to support@mydonedone.com? Would love to hear more.

Cheers,

Craig Bryant

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Hey Ben - Thanks for checking in, and for reporting the issue. I've forwarded to Mustafa, who is the loving father and caretaker of the DD api. Once he's had a peek and gives a nod and wink to how long it'll take to get patched up, I'll be in touch. Also, interested in learning a bit about what you're building. If you have a minute or two, can you send along a quick email to support@mydonedone.com? Would love to hear more. Cheers, Craig Bryant

How does this make you feel? Add Image

I'm
e.g. kidding, amused, unsure, silly indifferent, undecided, unconcerned sad, anxious, confused, frustrated happy, confident, thankful, excited
Cancel
0

Edit

Delete

Remove

Official

Ben January 17, 2012 17:37

Bah, looks like it's something in my javascript code, probably an encoding thing. I threw together a quick PHP test script and that worked fine without anything too special.

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Bah, looks like it's something in my javascript code, probably an encoding thing. I threw together a quick PHP test script and that worked fine without anything too special.

How does this make you feel? Add Image

I'm
e.g. kidding, amused, unsure, silly indifferent, undecided, unconcerned sad, anxious, confused, frustrated happy, confident, thankful, excited
Cancel
1

Edit

Delete

Remove

Official

Ben February 04, 2012 19:25

So I figured out the root of the problem. When using XmlHttpRequest and FormData class to send data, something doesnt get sent right. When creating the multipart form body by hand, it works. See example here:

For more info, see the commit referenced by this github issue https://github.com/zajax/notdone-chro...

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

So I figured out the root of the problem. When using XmlHttpRequest and FormData class to send data, something doesnt get sent right. When creating the multipart form body by hand, it works. See example here: For more info, see the commit referenced by this github issue https://github.com/zajax/notdone-chrome/issues/2

How does this make you feel? Add Image

I'm
e.g. kidding, amused, unsure, silly indifferent, undecided, unconcerned sad, anxious, confused, frustrated happy, confident, thankful, excited
Cancel
EMPLOYEE

1

Edit

Delete

Remove

Official

WAM - DoneDone (Official Rep) February 06, 2012 19:44

Hey Ben

Thanks for the update - glad you were able to get to the root of the issue. Thanks also for sharing it via github.

We've just put up some api wrappers in Python, PHP, and C# on our Github page, too, in case you have other projects that you want to work on and don't want to spend time re-integrating with the API. They're pretty simple for now but may be a good starting point in the future.

https://github.com/getdonedone

Thanks again!

Mustafa

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Hey Ben Thanks for the update - glad you were able to get to the root of the issue. Thanks also for sharing it via github. We've just put up some api wrappers in Python, PHP, and C# on our Github page, too, in case you have other projects that you want to work on and don't want to spend time re-integrating with the API. They're pretty simple for now but may be a good starting point in the future. https://github.com/getdonedone Thanks again! Mustafa

How does this make you feel? Add Image

I'm
e.g. kidding, amused, unsure, silly indifferent, undecided, unconcerned sad, anxious, confused, frustrated happy, confident, thankful, excited
Cancel

Reply to This Topic (some HTML allowed)
What's the status of this problem?

How does this make you feel? Add Image

I'm
e.g. kidding, amused, unsure, silly indifferent, undecided, unconcerned sad, anxious, confused, frustrated happy, confident, thankful, excited

About this Problem

Official Representatives

Products & Services

Tagged

API Signature Problem: Newlines in Descriptions

Edit Subject

About this Problem

Official Representatives

Products & Services

Tagged

API Signature Problem: Newlines in Descriptions Edit Subject

API Signature Problem: Newlines in Descriptions

Edit Subject